Jump to content

Template talk:Infobox NFL biography

Page contents not supported in other languages.
From Wikipedia, the free encyclopedia

Draft info

[edit]

@Dissident93: I'm OK with your changes to move away from slashes for the draft info;[1] it was never really consistent with MOS:SLASH. However, the new format, e.g. NFL draft: 1973 (round: 3 • pick: 64), seems semi-cryptic with the parens, colons, and bullet. Could we alternatively use more natural English, similar to Template:Infobox basketball biography, e.g. NFL draft: 1973: 3rd round, 64th overall pick? —Bagumba (talk) 06:48, 15 March 2025 (UTC)[reply]

Sure, the NBA code might need a bit of tweaking for use here but I'll try and see if I can get it working on a sandbox later. ~ Dissident93 (talk) 00:38, 16 March 2025 (UTC)[reply]
It's basically just using {{ordinal}}. I don't think "overall" (to distinguish from pick in the round) will fit without some tweaking, but then the NFL ibx never had it anyways. —Bagumba (talk) 03:46, 16 March 2025 (UTC)[reply]
It's implemented now. I tried testing it with overall but it wrapped around in infoboxes that lacked images (which makes them slightly wider) and it's not really necessary anyway. The only thing I'd still like to see is automatic linking to the lists of first and second overall pick pages, but I think I'd need to have the manual links that currently exist on each individual page removed first. ~ Dissident93 (talk) 15:43, 16 March 2025 (UTC)[reply]
Yeah, like the manual link for Peyton Manning goes to the redirect List of first overall National Football League Draft picks instead of the direct link List of first overall NFL draft picks. You could code up the template for plain "1" and "2", for simplified use for any future drafts. Then at any point later the old articles can have their links stripped from the wiki text, causing the template to encode it. —Bagumba (talk) 16:27, 16 March 2025 (UTC)[reply]
That's the plan. Removing the links is pretty simple with AutoWikiBrowser so it shouldn't take much effort. ~ Dissident93 (talk) 19:49, 16 March 2025 (UTC)[reply]
It's implemented now. ~ Dissident93 (talk) 21:52, 16 March 2025 (UTC)[reply]
@Dissident93: Gerald McNeil's supplemental draft display is broken (not sure if necessarily the recent changes). —Bagumba (talk) 00:33, 18 March 2025 (UTC)[reply]
That's because his article and all others from the 1984 NFL supplemental draft of USFL and CFL players used manual links. I've made values of 1984 link to that page instead and added the |suppdraftpick= parameter since that draft also had pick numbers (other supplemental draft picks only account for round). They should all be following the same formatting as any other NFL draft now. ~ Dissident93 (talk) 02:00, 18 March 2025 (UTC)[reply]
@Dissident93: Some more bizzare formats encoded into "round" like Charlie McNeil (American football) and Walter Beach. Is there a definitive way to find all the non-numeric inputs? —Bagumba (talk) 09:27, 25 March 2025 (UTC)[reply]
@Dissident93: And this one crams the draft team into the draft pick. Do we tweak the template or run something like AWB to find and update the pages' encoding? —Bagumba (talk) 04:52, 26 March 2025 (UTC)[reply]
Seems like this issue is just for the 1960 AFL draft? Only numeric values should be used in |afldraftround=, the rest of them have to be manually fixed but I'm not sure if there's a definite way to find them all. ~ Dissident93 (talk) 16:03, 26 March 2025 (UTC)[reply]
I've made it so all 1960 AFL draft picks ignore |afldraftround= and |afldraftpick= since that draft didn't seem to use that? They should still be removed locally from articles but no longer get displayed. ~ Dissident93 (talk) 16:52, 26 March 2025 (UTC)[reply]
@Dissident93 I figured out how to get command line regex to work here. Seems it's more than 1960 AFL draft. —Bagumba (talk) 11:02, 27 March 2025 (UTC)[reply]
I guess if it's piped to a number it works out OK. Some have "Undrafted" though, which turns into "Undraftedth round". —Bagumba (talk) 11:08, 27 March 2025 (UTC)[reply]
I can go through the list and fix them myself. It looks like |aflundrafted= is needed for some unless the issue that Kansas Comet 48 (I'm aware they're a blocked sockpuppet) brought up isn't that big of a deal. Some of these drafts also have "red shirt" rounds that should also be accounted for, but I'm not sure if it needs a unique parameter or if displaying "Red shirt 3(rd)" like Jan Stenerud is acceptable. ~ Dissident93 (talk) 22:59, 27 March 2025 (UTC)[reply]
I'd like to suggest a change. Now that the format is different, I'd like to see a parameter for undrafted free agents that signed with an AFL (1960–1969) team. Some really good players like Dick Harris, Speedy Duncan or HOFer Willie Brown did not sign with any NFL team coming out of college. So now I think it's a good time to add a parameter for that players. Kansas Comet 48 (talk) 19:45, 24 March 2025 (UTC)[reply]
Personally I don't think that's a good idea / implementation. The AFL actually succeeded in large part because they were able to offer equal or more money to prospective free agents. It's not necessarily indicative of anything. Hey man im josh (talk) 19:53, 24 March 2025 (UTC)[reply]
You're right about it, but I mean if we use | undraftedyear = it would redirect to the notable UDFAs of NFL teams. For whatever reason, they did not signed with an NFL team. As we know, the NFL and AFL were separated leagues from 1960 to 1969. Kansas Comet 48 (talk) 22:03, 24 March 2025 (UTC)[reply]
|aflundrafted= could be added to match NFL and CFL. ~ Dissident93 (talk) 16:54, 26 March 2025 (UTC)[reply]
@Bagumba I'm finally starting to go through the list you provided and cleaning it up. The only issue I have is with the 1960 AFL draft with the "First" and "Second Selections". The article just lists them by team and not any sort of round unless I'm missing it, so I'm using only |afldraftyear=. ~ Dissident93 (talk) 23:50, 27 May 2025 (UTC)[reply]

Image size parameter

[edit]

I removed |image_size= as forced pixel sizes are discouraged per Module:InfoboxImage, citing WP:IMAGESIZE as the policy. ~ Dissident93 (talk) 22:06, 16 March 2025 (UTC)[reply]

How do we adjust the sizes of images now? That was used on thousands of images. For example, the image is too big at Roy Gagnon now since that parameter doesn't work anymore. ~WikiOriginal-9~ (talk) 22:20, 16 March 2025 (UTC)[reply]
I've made |upright= a parameter now. The vast majority of images for this infobox don't need re-sizing (most of them were small for no reason) but in cases with older photos that look bad blown up, values less than 1 can be used to scale down. I'll revert if this a bigger issue than expected, but I personally see that as having more issues than manually fixing the more uncommon cases like Gagnon's. ~ Dissident93 (talk) 03:34, 17 March 2025 (UTC)[reply]
@Hey man im josh: Would you be willing to create a maintenance category for all articles using image_size so I can fix any oversized images? I'm still coming across some oversized images like at Keith Flowers (already fixed). These aren't appearing in Category:Pages using infobox NFL biography with unsupported parameters for some reason? I remember you mentioning that cat before so that's why I'm asking you about this. Thanks, ~WikiOriginal-9~ (talk) 17:54, 31 March 2025 (UTC)[reply]
@WikiOriginal-9: I don't actually know how to create that category, but I'd be happy to help deal with it. Hey man im josh (talk) 17:55, 31 March 2025 (UTC)[reply]
You simply remove it from below Page using Template:Infobox NFL biography with unknown parameter "_VALUE_". I didn't do that at the time as I wanted to wait and see if anything broke or didn't look right but it seems fine. ~ Dissident93 (talk) 20:23, 31 March 2025 (UTC)[reply]
Tracking category (Category:Infobox NFL biography articles using image size) also created. I'm also thinking about making one tracking raw <br> tags in |high_school=, as {{Nowrap}} should be used on the location as it linebreaks only if needed. ~ Dissident93 (talk) 21:05, 31 March 2025 (UTC)[reply]
Thanks for that. I wonder if there is anyway to automatically change, for example "image_size=150px" to whatever the corresponding upright value would be? Or are you hoping to minimize the use of upright unless necessary? ~WikiOriginal-9~ (talk) 22:18, 31 March 2025 (UTC)[reply]
How many cases have you found? Maybe we could remove all cases above 250px and use AWB to set them to |upright=.8 if below that? ~ Dissident93 (talk) 23:29, 31 March 2025 (UTC)[reply]
Actually, I've checked a bunch of these and the upright parameter seems to be working fine so it's probably okay to just remove image_size. ~WikiOriginal-9~ (talk) 14:08, 1 April 2025 (UTC)[reply]
I do believe a number of other infoboxes also removed the image_size parameter, since it's automatically set. Hey man im josh (talk) 14:16, 1 April 2025 (UTC)[reply]
I went to go work on cleanup when I remembered Primefac has a bot task for removal of deprecated parameters. I've asked for assistance here. Hey man im josh (talk) 17:26, 1 April 2025 (UTC)[reply]

The pictures in the infoboxes are so big now. It looks ridiculous. They completely take over the infoboxes. Peyton Manning's forehead looks even bigger now. It's not just this infobox though, it's like this everywhere on Wikipedia due to recent changes with "upright", etc. There is a current discussion about it here. Just leaving this comment here for the historical record. Thanks all, ~WikiOriginal-9~ (talk) 14:11, 23 April 2025 (UTC)[reply]

Honestly I don't even notice a difference, what skin are you using @WikiOriginal-9? Vector 2022 by any chance? Hey man im josh (talk) 15:39, 23 April 2025 (UTC)[reply]
2010. ~WikiOriginal-9~ (talk) 15:40, 23 April 2025 (UTC)[reply]
Here's a before and after. ~WikiOriginal-9~ (talk) 20:24, 23 April 2025 (UTC)[reply]
Yes, the default thumbnail width increased from 220px to 250px, as announced and as had been requested for many years. I don't think changing the size of Peyton Manning's forehead is within the scope of MediaWiki development, but you are welcome to file a forehead-related bug on Phabricator, with the National Football League, or with Archie and Olivia. – Jonesey95 (talk) 14:45, 24 April 2025 (UTC)[reply]

Any idea how to fix the micro-sized picture at Mike Williams (American football, born 1957)? I increased the upright but that doesn't work. ~WikiOriginal-9~ (talk) 14:41, 21 May 2025 (UTC)[reply]

I think you'd have to do something like |image=[[File:DGAFVPMMFAZMLGI.20140109181116.jpg|100px]], bypassing thumbnail for an already minuscule pic. But such a low-res pic gets fuzzier as you blow it up. Perhaps just find a better one, as it's WP:NFC anyways. —Bagumba (talk) 18:30, 21 May 2025 (UTC)[reply]
I think it's because it's below 250px? Module:InfoboxImage says |upright= displays image at 75% of default image size (which is 250px if not changed at Special:Preferences. Images that tiny are probably never expected to be used, but at least there's a workaround if necessary. ~ Dissident93 (talk) 00:51, 22 May 2025 (UTC)[reply]

Extra space

[edit]

It appears there is some extra white space above the CFL archive link on infoboxes now. See Travis Partridge. ~WikiOriginal-9~ (talk) 16:25, 31 March 2025 (UTC)[reply]

Jonesey95 (talk · contribs) added a linebreak tag there citing a lint error. ~ Dissident93 (talk) 20:26, 31 March 2025 (UTC)[reply]
You can see the problem that I fixed in the sandbox version of the test case called "All stat links, old CFL link". There may be a better way to fix this problem, which is related to the undocumented |cfl-archive= parameter. Feel free to experiment in the template sandbox. – Jonesey95 (talk) 21:51, 31 March 2025 (UTC)[reply]

Undrafted year

[edit]

Not sure that's an improvement. Kurt Warner looks weird having the year blank. In regards to the American Football League, a lot of players were selected in both drafts back then. That's not a big enough issue to warrant removing everything. If someone was only selected in one draft, then the undraftedyear can just be left blank like at Harry Schuh. ~WikiOriginal-9~ (talk) 23:15, 27 May 2025 (UTC)[reply]

It automatically links to that year's respective NFL draft even if they never played in the NFL. An |aflundraftedyear= parameter could be created for AFL-only players and automatically be hidden if |undraftedyear= is also used for players that played in both leagues. ~ Dissident93 (talk) 23:56, 27 May 2025 (UTC)[reply]
Bagumba, why not just add the link back to 1994_NFL_draft#Notable_undrafted_players like before? That's where Kurt Warner is listed at on that page. ~WikiOriginal-9~ (talk) 14:07, 28 May 2025 (UTC)[reply]
@WikiOriginal-9: Didn't realize you already raised a concern here. I restored it. @Dissident93: These types of edits should get prior consensus per WP:TPECON, as non-TEs who object can't just revert it. —Bagumba (talk) 15:37, 28 May 2025 (UTC)[reply]
Incidentally, I wasnt a big fan of linking to the section, people can navigate their way from the TOC, and Dissident93 had mentioned some page's not having that section, so I considered it a compromise. FWIW, NBA infoboxes just link to the draft page, not an undrafted section. —Bagumba (talk) 15:43, 28 May 2025 (UTC)[reply]
|aflundraftedyear= has been added. The text automatically disambiguates between the NFL, CFL, and AFL if they were drafted (or undrafted) in another league, otherwise it defaults to Undrafted: like before. I kept the links directed towards the notable UDFA section until further discussion. Could a link to all AFL UDFAs be generated so they can use it? I'll handle the rest as I slowly clean these ones with invalid values. ~ Dissident93 (talk) 19:51, 28 May 2025 (UTC)[reply]
@Dissident93: I think the most recent change to this infobox removed the "roster status" from appearing on infoboxes. Eagles 24/7 (C) 13:13, 29 May 2025 (UTC)[reply]
Good catch, it was the data # being overridden from the new parameter. ~ Dissident93 (talk) 23:02, 29 May 2025 (UTC)[reply]

I've only realized now that the infobox shows "Undrafted: 1994" (even before recent changes), instead of just following the normal draft syntax with like "NFL draft: 1994: undrafted" (see basketball player like Austin Reaves). Then showing a parenthetical like "Undrafted (NFL): 1994" (see Tim Tindale) looks cryptic. Infobox fields are typically nouns like "NFL draft", not adjectives like "Undrafted".—Bagumba (talk) 14:40, 29 May 2025 (UTC)[reply]

This does look way cleaner and simplifies the infobox as well. ~ Dissident93 (talk) 23:13, 29 May 2025 (UTC)[reply]
@Bagumba: Nobody seemed to oppose this, so it's live now. ~ Dissident93 (talk) 23:16, 30 May 2025 (UTC)[reply]
I don't know, seems weird on lower-level players like Arena Football League players when NFL draft is specifically highlighted in the infobox when they weren't really a prospect anyway. Like Nick Davila ("rated as the 60th-best quarterback in the draft") Looked better when it just said undrafted. ~WikiOriginal-9~ (talk) 23:41, 30 May 2025 (UTC)[reply]
It's otherwise MOS:EGGy what "Undrafted" is linking to. If the draft is insignificant, the other option is for editors to consciously leave it blank. But I think it's relevant as a clue to why someone didn't play in the NFL. If they were Canadian and weren't drafted by the NFL and never played in the NFL, then I think the NFL draft can be left out (esp. if didnt play college in US); that would be consistent with basketball and non-domestic players not showing undrafted for the NBA. —Bagumba (talk) 01:14, 31 May 2025 (UTC)[reply]
No one is confused as to what undrafted means. It's undue weight to have NFL draft specifically listed on literally every gridiron article now. Are people going to start putting both NFL draft: undrafted and AFL draft: undrafted on select articles now? If someone only played in the American Football League, "Undrafted" can just link to the AFL draft. ~WikiOriginal-9~ (talk) 02:26, 31 May 2025 (UTC)[reply]
It's undue weight to have NFL draft specifically listed on literally every gridiron article now: I haven't looked at the implementation. Are you saying it's linked on pages now where it wasn't before, or just that it's labelled "NFL draft" now but the links are unchanged? —Bagumba (talk) 03:43, 31 May 2025 (UTC)[reply]
If the issue is with non-NFL players then it could be made to omit NFL from being displayed by cross-checking |draftround= / |cfldraftround= / |afldraftround=. Is there a specific article that doesn't look right? ~ Dissident93 (talk) 15:36, 2 June 2025 (UTC)[reply]
Retrieved from "https://en.wikipedia.org/w/index.php?title=Template_talk:Infobox_NFL_biography&oldid=1293588966"